Skip to content

Comments

Reproduced texture size issue (WebGPU) using Material Design Icons font + Dear Imgui's wchar32 feature/setting.#29

Open
andreamancuso wants to merge 2 commits intomainfrom
issue-repro/material-design-icons-wchar32
Open

Reproduced texture size issue (WebGPU) using Material Design Icons font + Dear Imgui's wchar32 feature/setting.#29
andreamancuso wants to merge 2 commits intomainfrom
issue-repro/material-design-icons-wchar32

Conversation

@andreamancuso
Copy link
Collaborator

@andreamancuso andreamancuso commented Jun 3, 2024

Re-created issue based on discussion: ocornut/imgui#7649

image

@andreamancuso andreamancuso added the wontfix This will not be worked on label Jun 3, 2024
@andreamancuso
Copy link
Collaborator Author

andreamancuso commented Jun 3, 2024

Keeping this PR open to serve as a reminder re: we must stick to Font Awesome icons for now.

@andreamancuso
Setting icons_config.OversampleH = 1 - which does fix the texture siz…
13ac346 
…e issue. Unfortunately there's a 15 second long period of very high (100%) CPU utilisation before the application gets rendered.
@andreamancuso
Copy link
Collaborator Author

andreamancuso commented Jun 3, 2024 •
edited
Loading

Setting icons_config.OversampleH = 1; initially appeared to have fixex the texture size issue. This also caused a 15 second long period of very high (100%) CPU utilisation before the application gets rendered.

Setting io.Fonts->TexDesiredWidth = 4096; didn't seem to make a difference.

After a while, the texture size issue was back and I was unable to get the application to render anymore.

@andreamancuso
Copy link
Collaborator Author

andreamancuso commented Jun 10, 2024

The only concrete solution for this is to include web font files containing exclusively the icons actually being used within the application. This used to be a thing over a decade ago in the web world - I should hope this won't be overly difficult in 2024...

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

wontfix This will not be worked on

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@andreamancuso